Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/669?usp=email )
Change subject: t_server_null: multiple improvements and fixes ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: OK, so the NetBSD problem seems to be "umask" - when run from BB, the server processes are started (sudo openvpn...) just fine - the resulting PID file (and Log file) are 600 ``` -rw------- 1 root users 6 Jul 3 16:22 t_server_null_server-1194_udp.pid -rw------- 1 root users 5 Jul 3 16:22 t_server_null_server-1195_tcp.pid -rw------- 1 root users 227 Jul 3 16:24 t_server_null_server-1195_tcp.status -rw------- 1 root users 1991 Jul 3 16:24 t_server_null_server-1195_tcp.log -rw------- 1 root users 227 Jul 3 16:24 t_server_null_server-1194_udp.status -rw------- 1 root users 1824 Jul 3 16:24 t_server_null_server-1194_udp.log ``` - some other element running as non-root cannot read the pid file, so assumes "the server process must have been not started", and neither proceeds with the client - since "the server has not been started" it's not killed either, and on the next run, the port is in use My suggestion would be to add an `umask 022` to the script that starts the server processes (I do not feel like digging into "why does BB set 077, when the system default is 022", and it *will* bite someone else running from the CLI eventually) Also, error handling, for "there is a file and I can't read it". -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/669?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff673d8590b6b3a Gerrit-Change-Number: 669 Gerrit-PatchSet: 4 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Wed, 03 Jul 2024 14:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
