Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/672?usp=email )
Change subject: Allow trailing \r and \n in control channel message ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: getting close File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/672/comment/fbe5364d_eb37f3f4 : PS2, Line 302: int buflen = (int)strlen(BSTR(&buf)) + 1; While this is besser than the original, I find it still confusing to call `strlen()` twice on the very same string, in direct sequence. What's wrong with `int buflen = cmdlen +1;`...? http://gerrit.openvpn.net/c/openvpn/+/672/comment/46ed5072_d7aeafa2 : PS2, Line 318: format_hex(BPTR(&buf), BLEN(&cmdbuf), 256, &gc)); > While it is not actually wrong to use BPTR(&buf) here, I would recommend > BPTR(&cmdbuf). […] It is "not wrong today", but this sort of booby trap will come back and bite us later - so this should both be `&cmdbuf` if that's the buffer we have looked at (especially with new code in the pipeline that might handle multiple commands in a single TLS record etc) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/672?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I47c992b6b73b1475cbff8a28f720cf50dc1fbe3e Gerrit-Change-Number: 672 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 08 Jul 2024 19:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
