пн, 8 июл. 2024 г. в 23:13, Antonio Quartulli <a...@unstable.cc>:
>
> Hi,
>
> On 08/07/2024 23:08, Ilia Shipitsin wrote:
> > Signed-off-by: Ilia Shipitsin <chipits...@gmail.com>
> > ---
> > src/openvpn/init.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/src/openvpn/init.c b/src/openvpn/init.c
> > index a49e5639..59205ba6 100644
> > --- a/src/openvpn/init.c
> > +++ b/src/openvpn/init.c
> > @@ -4967,6 +4967,10 @@ write_pid_file(const char *filename, const char
> > *chroot_dir)
> > if (!chroot_dir)
> > {
> > saved_pid_file_name = strdup(filename);
> > + if (!saved_pid_file_name)
> > + {
> > + msg( M_FATAL, "Failed allocate memory
> > saved_pid_file_name");
>
> patchset looks great, but (!!) there should be no space after the
> opening parenthesis..
I just followed code style already present in repo
$ grep -r 'msg( M_FATAL' .
grep: ./.git/objects/pack/pack-d09f3eabac42224b1dc52ffb4f53d9af23bc5b7d.pack:
binary file matches
./src/openvpn/auth_token.c: msg( M_FATAL, "Failed to get enough
randomness for "
./src/openvpn/tun.c: msg( M_FATAL, "init_tun: problem
converting IPv6 ifconfig addresses %s and %s to binary",
ifconfig_ipv6_local_parm, ifconfig_ipv6_remote_parm );
./src/openvpn/tun.c: msg( M_FATAL, "cannot find unused tap device" );
./src/openvpn/tun.c: msg( M_FATAL, "TAP device name must be
'--dev tapNNNN'" );
also, uncrustify GHA jobs agreed that it is no formatting violation
>
> Cheers,
>
> > + }
> > }
> > }
> > }
>
> --
> Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
