Attention is currently required from: flichtenheld, plaisthos. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/665?usp=email )
Change subject: Static-challenge concatenation option ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: Thanks for the review. File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/665/comment/16c4a9ba_0d8e0e6a : PS2, Line 1333: FORMAT = bit 2 = 1 if response should be concatenated with password > Honestly it is not clear to me from this documentation on how these flags > combine. […] v2 is coming. File src/openvpn/misc.h: http://gerrit.openvpn.net/c/openvpn/+/665/comment/25e712cb_3f39cbc9 : PS2, Line 121: #define GET_USER_PASS_STATIC_CHALLENGE_CONCAT (1<<11) /* indicates password and response should be concatenated */ > Please add a test to the UT suite test_get_user_pass_static_challenge Test was submitted along with: see https://gerrit.openvpn.net/c/openvpn/+/666 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d Gerrit-Change-Number: 665 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair <selva.n...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 09 Jul 2024 13:22:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
