Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/670?usp=email )
Change subject: console_systemd: rename query_user_exec to query_user_systemd ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS3: I think this is a good change. I had one comment about the code-in-header and making them inline, though... what do you think? File src/openvpn/console.h: http://gerrit.openvpn.net/c/openvpn/+/670/comment/a68c3cbb_5ae4e68e : PS3, Line 94: static bool our normal convention seems to be "if there is code in .h files, it's tagged as inline". I can see that this is not true for the existing query_user_exec() wrapper, but maybe we want to fix this as well here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/670?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I379e1eb6dc57b9fe4bbdaefbd947a14326e7117a Gerrit-Change-Number: 670 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 25 Jul 2024 15:55:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
