cron2 has uploaded a new patch set (#4) to the change originally created by 
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/671?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by uddr


Change subject: configure: Try to use pkg-config to detect mbedTLS
......................................................................

configure: Try to use pkg-config to detect mbedTLS

mbedTLS does not seem to have pkg-config support on e.g.
Debian/Ubuntu, so we definitely need to keep the
fallback check as well.

Change-Id: I5d0da76018e874cda5dbab9202a2b817ad5e4692
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
Acked-by: Yuriy Darnobyt <yura.u...@gmail.com>
Message-Id: <20240906160510.76387-1-fr...@lichtenheld.com>
URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29090.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
---
M configure.ac
1 file changed, 14 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/671/4

diff --git a/configure.ac b/configure.ac
index ea0da1f..9e569bf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1000,14 +1000,21 @@

        if test -z "${MBEDTLS_CFLAGS}" -a -z "${MBEDTLS_LIBS}"; then
                # if the user did not explicitly specify flags, try to 
autodetect
-               LIBS="${LIBS} -lmbedtls -lmbedx509 -lmbedcrypto"
-               AC_CHECK_LIB(
-                       [mbedtls],
-                       [mbedtls_ssl_init],
-                       [MBEDTLS_LIBS="-lmbedtls -lmbedx509 -lmbedcrypto"],
-                       [AC_MSG_ERROR([Could not find mbed TLS.])],
-                       [${PKCS11_HELPER_LIBS}]
+               PKG_CHECK_MODULES([MBEDTLS],
+                       [mbedtls >= 2.0.0 mbedx509 >= 2.0.0 mbedcrypto >= 
2.0.0],
+                       [have_mbedtls="yes"],
+                       [LIBS="${LIBS} -lmbedtls -lmbedx509 -lmbedcrypto"]
                )
+               # mbedtls might not have pkgconfig integration, so try manually
+                if test "${have_mbedtls}" != "yes"; then
+                       AC_CHECK_LIB(
+                               [mbedtls],
+                               [mbedtls_ssl_init],
+                               [MBEDTLS_LIBS="-lmbedtls -lmbedx509 
-lmbedcrypto"],
+                               [AC_MSG_ERROR([Could not find mbed TLS.])],
+                               [${PKCS11_HELPER_LIBS}]
+                       )
+               fi
        fi

        CFLAGS="${MBEDTLS_CFLAGS} ${PKCS11_HELPER_CFLAGS} ${CFLAGS}"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/671?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5d0da76018e874cda5dbab9202a2b817ad5e4692
Gerrit-Change-Number: 671
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: uddr <yura.u...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-MessageType: newpatchset
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to