Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email )
Change subject: Implement support for larger packet counter sizes ...................................................................... Patch Set 10: (3 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/109f8bbf_34e87541 : PS6, Line 2696: /* Ensure that for proto v3 is enabled fully or not at all */ > Ensure that both aead_tag_end and long_pkt_id are enabled for DATA_V3 ? Done http://gerrit.openvpn.net/c/openvpn/+/507/comment/d9907f20_32a208a8 : PS6, Line 2702: msg(D_PUSH_ERRORS, "OPTIONS ERROR: Aead tag at the end and 64 bit" > missing space after "bit" Done File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/507/comment/8de88348_c0036eed : PS6, Line 1528: impl_iv_len = cipher_ctx_iv_length(ctx->cipher) - packet_id_size(longiv); > why not move declaration of impl_iv_len here? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/507?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01e258e97351b5aa4b9e561f5b35ddc2318569e2 Gerrit-Change-Number: 507 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Tue, 10 Sep 2024 10:05:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
