Attention is currently required from: cron2, flichtenheld, plaisthos.

mattock has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )

Change subject: Add lwip support to t_server_null
......................................................................


Patch Set 9:

(1 comment)

Patchset:

PS8:
> What is the point of backgrounding stuff from an `--up` script that waits on 
> an (unrelated) foregrou […]
Yeah, I think that is definitely a better approach. Even better, it seems 
possible to do what you propose by changing the .ips file format to include the 
PID for the client. That way ping_lwip_clients() has the information it needs 
to kill the lwip openvpn processes. I also don't see any obvious ways this 
restructuring could break the rest of the logic in t_server_null_client.sh.

So, in normal cases ping_lwip_clients() would kill the lwip openvpn clients. A 
fallback would the self-termination in lwip_client_up.sh.

I'll start working on this.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 9
Gerrit-Owner: mattock <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jan 2025 05:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to