Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/764?usp=email )
Change subject: Add support for simultaneous use of UDP and TCP sockets ...................................................................... Patch Set 17: (12 comments) Patchset: PS17: more comments File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/e1ebc360_490d6327 : PS17, Line 3834: this (and the next) blank line are arguably good, and should be kept, no? http://gerrit.openvpn.net/c/openvpn/+/764/comment/8b76c90d_17966fbf : PS17, Line 228: if (ce->proto != PROTO_TCP && c->mode != CM_CHILD_TCP) what's the reason for this change? the conditions should be the same? http://gerrit.openvpn.net/c/openvpn/+/764/comment/9a35e34d_80fa4240 : PS17, Line 616: c->options.ce.proto = proto; this does not look right. So we advance to the next ce, but keep the proto? Wouldn't that break ``` <connection> remote ... udp <connection> remote ... tcp ``` setups? http://gerrit.openvpn.net/c/openvpn/+/764/comment/d8380160_cf33bdd0 : PS17, Line 2687: if (!proto_is_udp(c->c2.link_sockets[0]->info.proto) && c->options.ce.explicit_exit_notification) this like is getting a bit long, so I think wrapping might be a good thing http://gerrit.openvpn.net/c/openvpn/+/764/comment/e84b95dc_73633f8a : PS17, Line 2846: if (has_udp_in_local_list(&c->options)) this might be modelling the existing behaviour, but it's arguable whether the old behaviour was actually correct - a *server* should not do exponential backoff after a connection failure, no matter whether TCP or UDP. http://gerrit.openvpn.net/c/openvpn/+/764/comment/ff1ffcf7_a5d0582f : PS17, Line 3369: } given that `link_socket_proto_connection_oriented()` (nowadays) is a very long form of `if (!proto_is_dgram())` I don't think it makes sense to have the code this way - get rid of the `if()`, loop always. That said, grepping through the code, `to.tcp_mode` seems to be dead anyway - I see no user of it. Get rid of it completely, then ;-) File src/openvpn/mroute.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/e768a558_8ea1565c : PS17, Line 424: buf_printf(&out, ":%d", maddr.proto); we should not unconditionally add this `:%d`. It might be useful, but when MR_WITH_PORT is not set, it very much looks like `:6` or `:17` being the remote port. If we really want this, we should ascii-ize the proto and prepend (`tcp:1.2.3.4:1194`), no? File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/764/comment/cf0b5a07_5892252f : PS17, Line 1052: setenv_local_entry(es, o->ce.local_list->array[i], i+1); you have an i+1 here, and another i+1 inside `setenv_local_entry()`... what is it that you want to achieve here? http://gerrit.openvpn.net/c/openvpn/+/764/comment/2b3f667b_e3b3e51c : PS17, Line 3192: o->ce.proto = ce->proto; what is `o->ce.proto`? http://gerrit.openvpn.net/c/openvpn/+/764/comment/1bf199d4_7737bca5 : PS17, Line 3198: if (ce->local_list->array[i]->proto == PROTO_TCP) So we walk the list here, for the `--server` case, and then walk it again in `option_postprocess_mutate()` for all cases, correct? So we could just store the desired proto (TCP_SERVER etc) in `o->ce.proto` here and leave the walking the list to `option_postprocess_mutate()`? http://gerrit.openvpn.net/c/openvpn/+/764/comment/4ee90666_8e61c48d : PS17, Line 3838: msg(M_INFO, "NOTE: --fast-io is disabled while using multi-socket"); that comment needs to be something like `--fast-ip is disabled if there is a TCP socket active` or so ("using multi-socket" with multiple UDP sockets won't be a problem) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/764?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31bbf87e4e568021445c7512ecefadfd4a69b363 Gerrit-Change-Number: 764 Gerrit-PatchSet: 17 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Fri, 24 Jan 2025 21:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
