Attention is currently required from: flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/841?usp=email )
Change subject: dco_linux: extend netlink error cb with extra info ...................................................................... Patch Set 5: (1 comment) File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/841/comment/320d4cc7_2381270f : PS5, Line 34: * I think for two constant including a whole system header is really not great. I would rather see just having a copy of enum nlmsgerr_attrs {, maybe as enum ovpn_nlmsgerr_attrs { included in its own small snippet with the comments rather than having this big header added to our repo. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/841?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9e27ff335d892429334137d028f8503da4e4ca5b Gerrit-Change-Number: 841 Gerrit-PatchSet: 5 Gerrit-Owner: ordex <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Sun, 26 Jan 2025 09:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
