Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email )
Change subject: dco_linux: avoid bogus text when netlink message is not parsed ...................................................................... Patch Set 2: (1 comment) File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/1027/comment/641ebff7_a3997926 : PS2, Line 1254: /* no message was parsed - bail out */ I would change this to ``` /* no message for us to handle - platform specific code has logged details */ ``` because we do not really "bail out", we just do nothing because nothing is to be done. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I568faa12a5960e8b69de23c2df413b70b231592c Gerrit-Change-Number: 1027 Gerrit-PatchSet: 2 Gerrit-Owner: ordex <anto...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Fri, 23 May 2025 06:09:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
