Attention is currently required from: comododragon, flichtenheld. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email )
Change subject: Added PQE to WolfSSL ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: getting closer ;-) File README.wolfssl: http://gerrit.openvpn.net/c/openvpn/+/1046/comment/7ec159a7_61317087 : PS3, Line 40: option in a config. the textual logic is weird here - "to build with these PQE...", while "these PQE" are only defined in the next paragraph...? File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1046/comment/e1a1e35c_b06c65eb : PS3, Line 564: if (!SSL_CTX_set1_groups_list(ctx->ctx, groups)) please do not do that - that is, move code blocks around, just to have an easier time in the #ifdef As far as I can see all the patch really does is "change the #ifdef", but with a larger diff due to swapping the if/else parts this is harder to see, and will also mess up "git blame" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1046?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie0529c2074964b3be034f01e0ef53090a6edbd35 Gerrit-Change-Number: 1046 Gerrit-PatchSet: 3 Gerrit-Owner: comododragon <rein.vanbaa...@fox-it.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: comododragon <rein.vanbaa...@fox-it.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 11:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
