Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/809?usp=email ) Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 22: (3 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/1bf8ad22_b4ec599b : PS21, Line 2833: if (!is_update && !check_pull_client_ncp(c, found)) > does it make sense to suppress this check? It should never fail, and never > modify anything (as we p […] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/0b58e5d7_f3dccb6a : PS21, Line 5502: options_server_import(struct options *o, > please do not move them (as for 808). […] Done http://gerrit.openvpn.net/c/openvpn/+/809/comment/99a69d66_161a9554 : PS21, Line 3134: } > with the extra code, the comment before the function is no longer > appropriate. […] actually i should remove it, in case of an update of the option `routes->flags = 0`, so there is no need for this code. I think i forgot there from the previous development where i updated the flags individually. Tnx for the catch. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 22 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
