Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email )
Change subject: dco_linux: fix async message reception ...................................................................... Patch Set 4: Code-Review-1 (7 comments) Patchset: PS4: more polish needed File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1100/comment/24854dbd_add7b22c : PS4, Line 170: * Send a prepared netlink message and registers cb as callback if non-null. this comment needs changing, though... "and registers cb" http://gerrit.openvpn.net/c/openvpn/+/1100/comment/6281b84e_49f7ecd7 : PS4, Line 903: msg(M_WARN, "%s: no peer-id provided in reply", __func__); maybe change the "reply" to "whatever this message type is", similar to the other "no peer-id provided" things? http://gerrit.openvpn.net/c/openvpn/+/1100/comment/94873fa3_d40d8bb4 : PS4, Line 938: msg(M_WARN, "%s: no peer-id provided in reply", __func__); as well http://gerrit.openvpn.net/c/openvpn/+/1100/comment/41388847_81aa443f : PS4, Line 951: struct multi_instance *mi = dco->c->multi->instances[peer_id]; how can we ever end here? http://gerrit.openvpn.net/c/openvpn/+/1100/comment/5c6b04ae_b5f56bc3 : PS4, Line 1182: if (nlh->nlmsg_flags & NLM_F_MULTI) I'm not sure I understand this. p2mp peer messages are sent multicast, and p2p messages not? Or what does `NLM_F_MULTI` signal? http://gerrit.openvpn.net/c/openvpn/+/1100/comment/a876ff1f_882629d9 : PS4, Line 1189: } I do wonder if this `if()` shouldn't just look at p->mode? Since `multi` does not want to deal with MODE_P2P, and _peer() now has extra code to deal with !MODE_P"P, just check beforehand? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I23ad79e14844aefde9ece34dadef0b75ff267201 Gerrit-Change-Number: 1100 Gerrit-PatchSet: 4 Gerrit-Owner: ordex <anto...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Wed, 23 Jul 2025 18:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel