Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1102?usp=email
to review the following change.
Change subject: comp: Make sure comp flags are treated as unsigned
......................................................................
comp: Make sure comp flags are treated as unsigned
compress_options.flags is already unsigned. Make sure
the individual flags are as well to avoid spurious
conversion warnings.
Change-Id: I6a0d352a039a0936cb9bbedf6168cd6eecd053ea
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M src/openvpn/comp.h
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1102/1
diff --git a/src/openvpn/comp.h b/src/openvpn/comp.h
index 0bb0d32..ee9c16a 100644
--- a/src/openvpn/comp.h
+++ b/src/openvpn/comp.h
@@ -33,22 +33,22 @@
/* Compression flags */
/* Removed
- #define COMP_F_ADAPTIVE (1<<0) / * COMP_ALG_LZO only * /
- #define COMP_F_ALLOW_COMPRESS (1<<1) / * not only incoming is
compressed but also outgoing * /
+ #define COMP_F_ADAPTIVE (1u<<0) / * COMP_ALG_LZO only * /
+ #define COMP_F_ALLOW_COMPRESS (1u<<1) / * not only incoming is
compressed but also outgoing * /
*/
/** initial command byte is swapped with last byte in buffer to preserve
payload alignment */
-#define COMP_F_SWAP (1<<2)
+#define COMP_F_SWAP (1u<<2)
/** tell server that we only support compression stubs */
-#define COMP_F_ADVERTISE_STUBS_ONLY (1<<3)
+#define COMP_F_ADVERTISE_STUBS_ONLY (1u<<3)
/** Only accept stub compression, even with COMP_F_ADVERTISE_STUBS_ONLY
* we still accept other compressions to be pushed */
-#define COMP_F_ALLOW_STUB_ONLY (1<<4)
+#define COMP_F_ALLOW_STUB_ONLY (1u<<4)
/** push stub-v2 or comp-lzo no when we see a client with comp-lzo in occ */
-#define COMP_F_MIGRATE (1<<5)
+#define COMP_F_MIGRATE (1u<<5)
/** Compression was explicitly set to allow asymetric compression */
-#define COMP_F_ALLOW_ASYM (1<<6)
+#define COMP_F_ALLOW_ASYM (1u<<6)
/** Do not allow compression framing (breaks DCO) */
-#define COMP_F_ALLOW_NOCOMP_ONLY (1<<7)
+#define COMP_F_ALLOW_NOCOMP_ONLY (1u<<7)
/* algorithms */
#define COMP_ALG_UNDEF 0
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1102?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6a0d352a039a0936cb9bbedf6168cd6eecd053ea
Gerrit-Change-Number: 1102
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
