Attention is currently required from: flichtenheld, ordex, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email )

Change subject: dco: drop client prefix after DCO PEER_FLOAT notification
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
Actually it is just fixing one particular symptom, but we can get there in 
other paths as well - here's a reconnect that happened to trigger the "query 
stats now!" timer

```
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: checking for 
received messages
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: rtnl: received 
36 bytes
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 net_route_v6_del: 
fd00:abcd:220:201::/64 via fd00:abcd:220:2::1006 dev tun1 table 0 metric 100
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: checking for 
received messages
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: rtnl: received 
36 bytes
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 net_route_v6_del: 
fd00:abcd:220:200::74/128 via fd00:abcd:220:2::1006 dev tun1 table 0 metric 100
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: checking for 
received messages
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 sitnl_send: rtnl: received 
36 bytes
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 dco_get_peer: peer-id -1
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 ovpn-dco: received netlink 
message type=31 cmd=3 flags=0x0002
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 ovpn_handle_peer: parsing 
message for peer 0...
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 ovpn_handle_peer: received 
data for a non-existing peer 0
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 ovpn-dco: received netlink 
message type=31 cmd=3 flags=0x0002
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 ovpn_handle_peer: parsing 
message for peer 1...
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 dco_update_peer_stat / 
dco_read_bytes(1): 1064936
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 dco_update_peer_stat / 
dco_write_bytes(1): 1064360
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 dco_update_peer_stat / 
tun_read_bytes(1): 1040000
Jul 27 12:14:55 ubuntu2004 tun-udp-p2mp[297683]: 
freebsd-74-amd64/udp6:194.97.140.3:62210 peer-id=2 dco_update_peer_stat / 
tun_write_bytes(1): 1040000
```

no float involved, but still we have a "peer-id=2" prefix for "peer 1" counters.

So I would suggest to move the `clear_prefix()` call into the DCO functions 
that deal with incoming messages, most of which will not deal with "the client 
that is currently listed in the prefix".  Maybe `ovpn_handle_msg()` (which 
would need the quivalent patch for FreeBSD and Windows)?  Or something generic 
in `dco.c` that deals with DCO events?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24
Gerrit-Change-Number: 1116
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <anto...@mandelbit.com>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <anto...@mandelbit.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 10:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to