Attention is currently required from: flichtenheld, mrbff, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 21: Code-Review-1 (3 comments) Patchset: PS21: I'm fine with most of the new version, but I'm still not really happy with `apply_push_options()`. Sorry. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/f3fc7445_db3c4290 : PS21, Line 5524: { please get rid of this extra `if()` level. Both conditions are checked again inside, so this is not really adding anything but an indent level. http://gerrit.openvpn.net/c/openvpn/+/808/comment/37cf1615_f21e2c77 : PS21, Line 5532: || (options->pull_filter_list && !apply_pull_filter(options, &line[i]))) I find this very hard to understand, even if it's a bit more space-efficient than having two `if()` clauses with their own error handling - but the latter would make the whole flow easier to understand. Maybe just leaving the `option->pull_filter_list` check inside `apply_pull_filter()` (as it was) would already make this easier to read. Yes, we'd waste a function call per received push-option, but this is not a critical code path. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 21 Gerrit-Owner: mrbff <ma...@mandelbit.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: mrbff <ma...@mandelbit.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Sun, 27 Jul 2025 12:19:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
