Attention is currently required from: flichtenheld, mrbff, plaisthos, stipa.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/869?usp=email ) Change subject: PUSH_UPDATE message sender: enabling the server to send PUSH_UPDATE control messages ...................................................................... Patch Set 21: Code-Review-1 (3 comments) Patchset: PS21: getting there File doc/management-notes.txt: http://gerrit.openvpn.net/c/openvpn/+/869/comment/6ddb1ed1_95abe02b : PS16, Line 1075: > i mostly followed the `kill` command, but yes it is the second one. So we discussed this at the community meeting today, and we should go for "do only what people really need" (= testing, maintenance) - so, `push-update-cid` and `push-update-broad` should stay, and `cn` and `addr` are left out. File src/openvpn/push.h: http://gerrit.openvpn.net/c/openvpn/+/869/comment/8416a3dd_3e281a0d : PS16, Line 54: > you can get the cid only from management, but theoretically the rest could be > used by other function […] As we have no other communication channels in OpenVPN 2.x today that can asynchronously decide "we need new options at a client now!" (plugins or scripts are only called on connect, and not "while a client is connected") this first patch should be "management only". So please make the `#ifdef ENABLE_MANAGEMENT` thing wider, and include all of the new code and data structures. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/869?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie82bcc7a8e583de9156b185d71d1a323ed8df3fc Gerrit-Change-Number: 869 Gerrit-PatchSet: 21 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 14:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: mrbff <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
