Tested this on client and server side, with and without DCO.
Can confirm that "counters with DCO" did not work without this patch,
and also the change to just get the counters from DCO once for all
peers is obviously beneficial for larger instances.
It took me a while to understand the multiple levels of code
complexity that were there *before* (management_bytes_client() doing
something totally different than management_bytes_server(), for
example) - so thanks a lot for refactoring this, the result is
much easier to understand, and due to the event based timing,
bytecounts are properly printed "on schedule" now (sometimes +1-2
seconds due to coarse timer granularity).
The mailing list and mail-archive.org are not playing nicely today,
so I've linked to the sourceforge.net list archive instead.
Your patch has been applied to the master branch.
commit da309c1e8bed7b9c25e800499400c8ad908276db
Author: Lev Stipakov
Date: Tue Sep 2 12:36:01 2025 +0200
Refactor management bytecount tracking
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL: https://sourceforge.net/p/openvpn/mailman/message/59228150/
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
