Attention is currently required from: flichtenheld, plaisthos, ralf_lici. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1166?usp=email )
Change subject: dco_linux: validate tun interface before fetching stats ...................................................................... Patch Set 1: Code-Review-2 (2 comments) Patchset: PS1: breaks BYTECOUNT on Linux+DCO for me (`tuntap_defined()` always returns FALSE) File src/openvpn/dco_linux.c: http://gerrit.openvpn.net/c/openvpn/+/1166/comment/a34991d7_2990cc7c : PS1, Line 1187: if (!tuntap_defined(c->c1.tuntap)) this does not work, as it checks ``` return tt && tt->fd >= 0; ``` and with DCO, tt->fd is not set, so this totally breaks counters in client mode with DCO. It does not crash, though. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1166?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I40c11864745cc1619cb9cbf490b168f90feb5eac Gerrit-Change-Number: 1166 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 15:46:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
