Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1177?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: push-update-server: comment about
`buf_string_compare_advance()` usage in `send_single_push_update()`
......................................................................
push-update-server: comment about `buf_string_compare_advance()` usage in
`send_single_push_update()`
Change-Id: I73f8ad9bf105920f4bde357ea9dcf0e485f3f3cb
Signed-off-by: Marco Baffo <[email protected]>
---
M src/openvpn/push_util.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1177/2
diff --git a/src/openvpn/push_util.c b/src/openvpn/push_util.c
index bd3992b..f7a4fca 100644
--- a/src/openvpn/push_util.c
+++ b/src/openvpn/push_util.c
@@ -161,6 +161,10 @@
* will not be routed towards the client.
* For the same reason we later update the vhash too in
* `send_push_update()` function.
+ * Using `buf_string_compare_advance()` we mimic the behavior
+ * inside `process_incoming_push_msg()`. However, we don't need
+ * to check the return value here because we just want to `advance`,
+ * meaning we skip the `push_update_cmd' we added earlier.
*/
buf_string_compare_advance(&msgs[i], push_update_cmd);
if (process_incoming_push_update(c, pull_permission_mask(c),
option_types_found, &msgs[i], true) == PUSH_MSG_ERROR)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1177?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I73f8ad9bf105920f4bde357ea9dcf0e485f3f3cb
Gerrit-Change-Number: 1177
Gerrit-PatchSet: 2
Gerrit-Owner: mrbff <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
