Attention is currently required from: flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email )
Change subject: openvpnserv: Fix writing messages to the event log ...................................................................... Patch Set 1: (2 comments) File src/openvpnserv/common.c: http://gerrit.openvpn.net/c/openvpn/+/1188/comment/c9d63194_9fa73d93 : PS1, Line 209: NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR)&tmp, 0, NULL); Explict use of the unicode version "FormatMessageW" preferred. http://gerrit.openvpn.net/c/openvpn/+/1188/comment/6b08b575_87668df4 : PS1, Line 228: buf[_countof(buf) - 1] = L'\0'; Previously we removed openvp_swprintf etc. assuming this explicit null-termination is no longer required. (commit 130548fe). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I423c9880def0eb479abb72bef2e8034a73cf5905 Gerrit-Change-Number: 1188 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: selvanair <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 17:38:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
