Attention is currently required from: d12fk, flichtenheld, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email )
Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes ...................................................................... Patch Set 4: (13 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/db3aa800_00ffb55b : PS4, Line 7: Install host routes with onlink scope iroutes for ifconfig-push routes > to be honest, this title feels a bit cryptic 😄 […] I tried to make it a bit easier to understand what is happening here. http://gerrit.openvpn.net/c/openvpn/+/1192/comment/8599ca43_fae0473b : PS4, Line 10: of the configured device need to be added to the operating system to > the subject for "need" is "Additional IP addresses", but I think you meant "a > route to those IPs", r […] ifconfig-push can be used for both. To either pick a specific IP address of the pool or to specify an address outside of the pool. But pool is not really correct here either as we really care about --ifconfig here and not about --ifconfig-pool but --server typically sets to be the same. File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/86c25c1c_10f45ae8 : PS2, Line 317: When DCO is enabled, OpenVPN will install a /32 route for the local IP > Should this also be documented for `ifconfig-ipv6-push`? I already documented. You seem to have commented on version 2 after I uploaded v4. File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/17f06b05_a6c4c15f : PS4, Line 318: address > s/for/to/ […] Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/6b55d068_07d64a50 : PS4, Line 330: When DCO is enabled, OpenVPN will install a /128 route for the local IP > s/for/to/ Done File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/b545dc09_22feb536 : PS4, Line 729: /* Check if we added the local network as /32 route as it was not in > should we call it "client network", as "local" seems to be something local to > the server Done File src/openvpn/mroute.h: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/442f986d_d8c6b1d1 : PS2, Line 78: /* MRoute is an on link/scope address ather than a route */ > Typo r`ather` fixed already in v4. File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/413eed33_c08b5e0d : PS4, Line 672: * > forgot to document "mi" Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/f087988d_68fbfd53 : PS2, Line 4347: /** > Doxygen is already in the header file Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/8e1814c1_f9785b38 : PS4, Line 1251: msg(D_MULTI_LOW, "MULTI: Adding /32 on-link route for route %s -> %s", > s/for route/for ifconfig-push/ ? (like you wrote in the ipv6 case) Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/8e6958ef_74bd7374 : PS4, Line 1262: if (!primary) > for clarity sake, shouldn't this be an "else if"? […] Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/4d8bd6f0_6be3546b : PS4, Line 1315: if (!primary) > same Done http://gerrit.openvpn.net/c/openvpn/+/1192/comment/de75b4bc_4f184632 : PS4, Line 4353: */ > I think we normally put the doxygen in one place only (i.e. header file), so > this can go. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff Gerrit-Change-Number: 1192 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: d12fk <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 10:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]> Comment-In-Reply-To: d12fk <[email protected]> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
