So this has a bit of a complicated journey - the initial patch was
gerrit 1183 for 2.6, which had v1..v3, and then this one for master,
which only got up to v2 but is now the same code change, essentially.

I have tested a 2.6 installer with this, and it makes really nice 
log entries in the event log - so definitely a MUST HAVE.

HEADS UP: when building installers with "autoconf" on mingw, this will
not currently produce the necessary .dll to proceed.  I'll send a patch
to add this.  The official way releases are built is "cmake with msvc"
or "cmake with mingw", and both produce the new .dll - and for "just
build a test openvpn.exe with configure/mingw" this is not critical
(which is what I usually do).

Your patch has been applied to the master branch.

commit 06919a60ae61d6d88546b23b52092f742599a8ae
Author: Lev Stipakov
Date:   Wed Sep 17 11:05:48 2025 +0200

     openvpnserv: Fix writing messages to the event log

     Signed-off-by: Lev Stipakov <[email protected]>
     Acked-by: Selva Nair <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1188
     Message-Id: <[email protected]>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59234559/
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to