Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email )
Change subject: Introduce msglvl_t to unify msglevel type handling ...................................................................... Patch Set 16: (1 comment) File src/openvpn/error.c: http://gerrit.openvpn.net/c/openvpn/+/1110/comment/e38154f9_4a81f5bc : PS16, Line 104: set_debug_level(const int level, const unsigned int flags) why not turning this into msglvl_t too? I see it normally gets passed o->verbosity, but it could also be turned to msglvl_t as well since it never gets assigned a negative number. The only situation to check is manage.c:1467. The mgmt interface technically accepts "verb -1", but it is a bogus case. We could force it to be positive as well. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1110?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id492cb774c6d022d06bb3cf5fec2a4bdd410e619 Gerrit-Change-Number: 1110 Gerrit-PatchSet: 16 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 08:13:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
