Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email )
Change subject: add building of openvpnsrvmsg.dll from eventmsg.mc to autoconf/mingw builds ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File src/openvpnserv/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/1197/comment/504cb947_ee947437 : PS2, Line 32: MSG00409.bin eventmsg.h eventmsg.rc openvpnservmsg.dll Is it intentional that `openvpnservmsg.dll` is in `noinst`? Shouldn't it be installed? http://gerrit.openvpn.net/c/openvpn/+/1197/comment/51bca724_b7505ca0 : PS2, Line 46: $(CC) -shared -Wl,--entry=0 -nostdlib -nostartfiles -o openvpnservmsg.dll eventmsg.o This looks like it might fail with out-of-tree builds. Can you please verify that it works. As a nitpick I would also recommend using `$@` and `$<` http://gerrit.openvpn.net/c/openvpn/+/1197/comment/8d382386_4d9818d6 : PS2, Line 51: $(WINDMC) -U eventmsg.mc same concerns here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1197?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0 Gerrit-Change-Number: 1197 Gerrit-PatchSet: 2 Gerrit-Owner: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 09:59:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
