Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1194?usp=email )

Change subject: ps: Fix conversion warnings related to send/recv return values
......................................................................


Patch Set 7: -Code-Review

(1 comment)

File src/openvpn/ps.c:

http://gerrit.openvpn.net/c/openvpn/+/1194/comment/db9519f8_851d0944 :
PS7, Line 575:         dmsg(D_PS_PROXY_DEBUG, "PORT SHARE PROXY: read[%d] %zd", 
(int)pc->sd, status);
> I should probably fix this to use SOCKET_PRINTF at the same time...
Nvm, I looked into it, and that would be a change worthy of its own commit



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1194?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id070d1a45d45f9029309d23df7f3cab9ce792205
Gerrit-Change-Number: 1194
Gerrit-PatchSet: 7
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 18 Sep 2025 14:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to