We used to reference to one of the mailing list archives as the formal reference for the patch and the review discussions. With the problematic reliability of the archives, I've started to manually add the URLs in the OpenVPN Gerrit to the commits because they give a better reference and (usually) all the feedback is there in a useful format.
So, enhance this dev-tool script to do this automatically. Change-Id: Idb137ecbade4b0584a4d74aee34978062e247bc5 Signed-off-by: Gert Doering <[email protected]> Acked-by: Frank Lichtenheld <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1196 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <[email protected]> diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 0b49ae9..450e920 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -99,6 +99,7 @@ assert comment_start > signed_off_end acked_by_text = "" acked_by_names = "" + gerrit_url = f"{args.url}/c/{details['project']}/+/{args.changeid}" for ack in details["acked_by"]: acked_by_text += f"Acked-by: {ack}\n" acked_by_names += f"{ack}\n" @@ -106,12 +107,13 @@ patch_text[:signed_off_end] + signed_off_text + acked_by_text + + f"Gerrit URL: {gerrit_url}\n" + patch_text[signed_off_end:comment_start] + f""" This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to {details["target"]}. -Gerrit URL: {args.url}/c/{details["project"]}/+/{args.changeid} +Gerrit URL: {gerrit_url} This mail reflects revision {details["revision"]} of this Change. {signed_off_comment} Acked-by according to Gerrit (reflected above): _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
