cron2 has uploaded a new patch set (#10) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1137?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: ssl: Fix -Wconversion warnings in pem_password_callback ...................................................................... ssl: Fix -Wconversion warnings in pem_password_callback The OpenSSL API is how it is, so adapt with casts. Change-Id: I053ddbb71cc5b9ae16c5a49be833035d943d7eba Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg33154.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/ssl.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/1137/10 diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 9159b8c..ba6919b 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -264,10 +264,10 @@ /* prompt for password even if --askpass wasn't specified */ pem_password_setup(NULL); ASSERT(!passbuf.protected); - strncpynt(buf, passbuf.password, size); + strncpynt(buf, passbuf.password, (size_t)size); purge_user_pass(&passbuf, false); - return strlen(buf); + return (int)strlen(buf); } return 0; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1137?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I053ddbb71cc5b9ae16c5a49be833035d943d7eba Gerrit-Change-Number: 1137 Gerrit-PatchSet: 10 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-MessageType: newpatchset
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
