This is not truly part of the "trivial integer related fixes" series,
more of the "ugh, how did we accept such horrible code, ever?" version...
I have stared-at-code a while, and then ran all the SOCKs test (admittedly
only "successful", so not testing timeouts and the like) but since this
is really 1:1 the same code (except for "return false" in the new function),
I do not expect surprises there. Tests all pass ;-)
Your patch has been applied to the master branch.
commit 9178a8ce73e9c5dd259522aa5e100116b965725b
Author: Frank Lichtenheld
Date: Tue Sep 23 17:10:44 2025 +0200
socks: factor out socks_proxy_recv_char()
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1165
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg33171.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
