Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1206?usp=email )
Change subject: platform: Do not assume uid_t/gid_t are signed ...................................................................... Patch Set 2: (2 comments) File src/openvpn/platform.c: http://gerrit.openvpn.net/c/openvpn/+/1206/comment/933bb202_973498c6 : PS2, Line 87: if (!pw) : { : msg(M_ERR, "failed to find UID for user %s", username); : } Shouldn't we set user_valid to false here? Or do we assume that the struct is initialized with 0? http://gerrit.openvpn.net/c/openvpn/+/1206/comment/a4d30325_3994e017 : PS2, Line 131: if (!gr) : { : msg(M_ERR, "failed to find GID for group %s", groupname); : } Shouldn't we set group_valid to false here? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1206?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie6b4c41d13544d5ba71d441cc794c7abd12408f3 Gerrit-Change-Number: 1206 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: MaxF <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 24 Sep 2025 16:33:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
