Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1193?usp=email )
Change subject: Allowing installing FreeBSD routes with interface instead of next-hop ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/openvpn/networking_freebsd.c: http://gerrit.openvpn.net/c/openvpn/+/1193/comment/ca46df8e_422ac899 : PS3, Line 23: /* if gw is 0 (=0.0.0.0), which is not a valid gateway, are you passing in NULL or "a pointer to 0.0.0.0"? The code says "NULL" and the comment says "gw is 0.0.0.0" which would technically be "a pointer to 0.0.0.0"... Maybe just word it the same as in IPv6... `if we have no gateway (gw is NULL), we are installing a route with the interface as target instead` or so. But the logic is still confusing, the comment says "if we have no gateway" and the condition does "if(gateway)" and the "interface route" is down in the else branch... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1193?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I88e16e15fad065cb310d38f09924053efc3a6ce5 Gerrit-Change-Number: 1193 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Sat, 27 Sep 2025 20:27:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
