Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1210?usp=email )
Change subject: redirect-gateway: only redirect traffic through TUN if address families match ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: This looks like it's not actually the correct way to do it - with the patch, a client that has a local `--ifconfig` configured will lose that on PUSH_REPLY, no matter what the server pushes. This is a valid use case and must not be broken. We do have the concept of "saved config data" which preserves what is in the client config - so `ifconfig` and `ifconfig-ipv6` need to be reset to "what is in the client config" before connecting out (PUSH_REPLY), otherwise we will break existing setups. For `PUSH_REPLY` I do not really care, as that's new functionality. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1210?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c Gerrit-Change-Number: 1210 Gerrit-PatchSet: 3 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 09:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
