Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1252?usp=email
to review the following change.
Change subject: crypto: Add more explicit casts for OpenBSD
......................................................................
crypto: Add more explicit casts for OpenBSD
The compiler on OpenBSD is a bit more zealous
about these strlen's even though these are
static values that can be determined at
compile time...
This was missed in the previous commit
("crypto: Make some casts to int explicit")
because we don't use -Werror on OpenBSD, yet.
Change-Id: Ia93bd8874e1b578d553720eedc274b974a462483
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/crypto.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/52/1252/1
diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c
index 13635fb..026e874 100644
--- a/src/openvpn/crypto.c
+++ b/src/openvpn/crypto.c
@@ -1361,8 +1361,8 @@
int state = PARSE_INITIAL;
/* constants */
- const int hlen = strlen(static_key_head);
- const int flen = strlen(static_key_foot);
+ const int hlen = (int)strlen(static_key_head);
+ const int flen = (int)strlen(static_key_foot);
const int onekeylen = sizeof(key2->keys[0]);
CLEAR(*key2);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1252?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia93bd8874e1b578d553720eedc274b974a462483
Gerrit-Change-Number: 1252
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
