Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1245?usp=email )
Change subject: PUSH_UPDATE: disabling PUSH_UPDATE server if DCO is enabled ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1245/comment/901153d2_c4cc2b99?usp=email : PS1, Line 304: " To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option."); ```suggestion " To send a PUSH_UPDATE message, be sure to use the --disable-dco option."); ``` Remove the quotes, we do not use them in other error messages. http://gerrit.openvpn.net/c/openvpn/+/1245/comment/ff703365_a978f0ce?usp=email : PS1, Line 320: " To send a PUSH_UPDATE message, be sure to use the `--disable-dco` option."); ```suggestion " To send a PUSH_UPDATE message, be sure to use the --disable-dco option."); ``` Remove the quotes, we do not use them in other error messages. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1245?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibe78949435bb2f26ad68301e2710321bf37c9486 Gerrit-Change-Number: 1245 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Wed, 01 Oct 2025 15:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
