cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1204?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend ...................................................................... configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend The prepend behavior is surprising. If there is a difference in behavior at least make it easy to understand what happens why. Change-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1204 Message-Id: <[email protected]> URL: https://sourceforge.net/p/openvpn/mailman/message/59237450/ Signed-off-by: Gert Doering <[email protected]> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/04/1204/3 diff --git a/configure.ac b/configure.ac index 38b14a1..0fc21ee 100644 --- a/configure.ac +++ b/configure.ac @@ -1388,9 +1388,9 @@ # required for gcc, but some compilers such as clang need it. AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [ old_cflags="$CFLAGS" - CFLAGS="$1 -Werror $CFLAGS" + CFLAGS="-Werror $CFLAGS $1" AC_MSG_CHECKING([whether the compiler accepts $1]) - AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$1 $old_cflags", + AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [AC_MSG_RESULT([yes])]; CFLAGS="$old_cflags $1", [AC_MSG_RESULT([no]); CFLAGS="$old_cflags"])] ) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1204?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff Gerrit-Change-Number: 1204 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-MessageType: newpatchset
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
