Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1217?usp=email )
Change subject: crypto: Make some casts to int explicit ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/1217/comment/04d4bd3a_735a3dad?usp=email : PS1, Line 1376: size = (int)(strlen(file) + 1); > You say that there are limits imposed so that this is safe, but I can't find > where that happens. […] This is actually good question. Normal parameters are limited to 256 characters, but after checking it seems inline parameters have no such limit. I will look further into this. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1217?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3b8dd8d5671e31dba2a23a0a78f36d9dda034b88 Gerrit-Change-Number: 1217 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: MaxF <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Tue, 30 Sep 2025 13:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
