Attention is currently required from: d12fk, flichtenheld, ordex, plaisthos.
cron2 has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes for ifconfig-push routes when DCO is enabled ...................................................................... Patch Set 11: (1 comment) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1192/comment/e8420035_d33ff056?usp=email : PS11, Line 4377: &o->push_ifconfig_ipv6_local)); > Ah, here we go. This fails if there is *no* `ifconfig-ipv6-push` in the > config, as then we have […] Maybe it would also be an idea to change `multi_check_push_ifconfig_ipv6_extra_route()` to not be passed a `mi` but the actual route we want to check? Both callers know what IPv6 address they want to be looked at (a6 / &mi->context.c2.push_ifconfig_ipv6_local) and actually passing *that* address would certainly make the code easier to understand... (For symmetry reasons, the same argument could be made for IPv4, of course) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I83295e00d1a756dfa44050b0a4493095fb050fff Gerrit-Change-Number: 1192 Gerrit-PatchSet: 11 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Sun, 19 Oct 2025 09:56:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
