Attention is currently required from: MaxF, plaisthos.

flichtenheld has posted comments on this change by MaxF. ( 
http://gerrit.openvpn.net/c/openvpn/+/1304?usp=email )

Change subject: Add option to check tls-crypt-v2 key timestamps
......................................................................


Patch Set 3: -Code-Review

Copied votes on follow-up patch sets have been updated:
* Copied Code-Review vote has been removed from patch set 4 (was Code-Review-2) 
since the new Code-Review=0 vote is not copyable (copy condition: 
"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").

(1 comment)

File src/openvpn/tls_crypt.c:

http://gerrit.openvpn.net/c/openvpn/+/1304/comment/f76fba9a_587eaa9c?usp=email :
PS2, Line 679:         return tls_crypt_v2_check_client_key_age(ctx, 
opt->tls_crypt_v2_max_age);
> That was bad, thanks for catching that! Should be fixed now.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1304?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0579d18c784e2ac16973d5553992c28f281a0900
Gerrit-Change-Number: 1304
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: MaxF <[email protected]>
Gerrit-Comment-Date: Mon, 27 Oct 2025 11:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: MaxF <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to