The "mask" bit is trivial (I have wondered a few times what it is for,
seems "for nothing" - out it goes!). The 0xff bit needed a bit more
thinking, but indeed, since we're only masking single-bytes at a time
here, and shift left, 0xffffff and 0xff is the same thing - and not
using an IPv4 constant for IPv6 seems like a proper thing to do!
Your patch has been applied to the master branch.
commit 2ae18239c30d96a4d16bc75a0204c4895e6cbce3
Author: Frank Lichtenheld
Date: Tue Oct 28 13:20:23 2025 +0100
mroute: Remove unused mask argument of mroute_get_in*
Signed-off-by: Frank Lichtenheld <[email protected]>
Acked-by: Gert Doering <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1309
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg33939.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
