Change is straightforward enough... interestingly enough I do have a
t_server test instance that is "p2p --mode tls-server with --push" so
I could test this right away...
2025-10-28 18:39:08 us=773113 Note: Using --push without --mode server is an
unsupported configuration. Negotiation of OpenVPN features is expected to fail.
.. and there you go. Indeed it then fails cipher negotiation (without
--pull on the other end, it won't PUSH_REPLY, but with --pull, it fails
p2p cipher negotiation... and goes to lala land)
Interesting find on PUSH_DEFINED()... you could have removed the redundant
PULL_DEFINED() as well, while at it. Next time.
Your patch has been applied to the master branch.
commit d6a0cf599c68edc672c67c6afa4bdff0e1a30b8a
Author: Arne Schwabe
Date: Thu Oct 23 17:56:08 2025 +0200
Warn if push is used without --mode server/--server/--server-bridge
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Frank Lichtenheld <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1288
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg33856.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
