Attention is currently required from: cron2, flichtenheld, plaisthos, selvanair.

d12fk has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email )

Change subject: iservice: validate config path better
......................................................................


Patch Set 4:

(1 comment)

File src/openvpnserv/validate.c:

http://gerrit.openvpn.net/c/openvpn/+/1307/comment/df0586da_23d5964d?usp=email :
PS4, Line 78:         res = PathCchCombine(config_path, sizeof(config_path), 
workdir, fname);
> size should be in characters, not sizeof() isn't it? Same below in 
> PathCchCanonicalize.
Good catch



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1307?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0e94068f467f2899daf133b032a785d2d7fc05e4
Gerrit-Change-Number: 1307
Gerrit-PatchSet: 4
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-CC: selvanair <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: selvanair <[email protected]>
Gerrit-Comment-Date: Fri, 07 Nov 2025 02:16:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: selvanair <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to