Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1336?usp=email ) Change subject: iservice: make sure directories have trailing \ ...................................................................... Patch Set 5: Code-Review-2 (2 comments) Patchset: PS5: does not compile on windows File src/openvpnserv/common.c: http://gerrit.openvpn.net/c/openvpn/+/1336/comment/5866c2c1_a20cb45c?usp=email : PS5, Line 71: return res == S_OK || res == S_FALSE ? TRUE : FALSE; please use braces here so it's clear to the casual reader what part of the boolean goes into the ternary operator -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1336?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If28e66fcc3493821f78fd14d432b22b996918e8f Gerrit-Change-Number: 1336 Gerrit-PatchSet: 5 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: stipa <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:14:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
