Attention is currently required from: d12fk, plaisthos.

flichtenheld has posted comments on this change by d12fk. ( 
http://gerrit.openvpn.net/c/openvpn/+/1362?usp=email )

Change subject: iservice: validate config path case-insensitive
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1362/comment/724daf9e_538e1abf?usp=email :
PS2, Line 9: Windows filesystems do not make a difference here, so should we.
While I believe that this is a valid meaning of "making a difference" it is not 
a common one. I would suggest "differentiate". And the "so should we" is 
confusing.

How about:

```suggestion
Windows filesystems do not differentiate by case, so we shouldn't either.
```



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1362?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d905da3add9b8a3daf349eb1bc830a017cf493d
Gerrit-Change-Number: 1362
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Mon, 10 Nov 2025 12:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to