Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1298?usp=email )
Change subject: ssl: Fix conversion warning in tls_prepend_opcode_v1 ...................................................................... Patch Set 4: (1 comment) File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/1298/comment/63437cc2_76f424ff?usp=email : PS3, Line 3985: ASSERT(ks->key_id <= 1 << P_OPCODE_SHIFT); > Can we add brackets here? I find this a bit hard to read since the order of > <= and << is not so supe […] That would be redundant with `P_KEY_ID_MASK` I guess, so how about just using that? Changed to that for now. But definitely right about the off-by-one. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1298?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I34584f695ddca3b3e1f2bbcb4380ac91b09c1c8d Gerrit-Change-Number: 1298 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 14:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
