Stared at the code, it does what it says on the lid, though I wonder
if that's a reasonable thing to do in all cases... "log_dir" seems to
be fully unused in the code base, and "bin_dir" is only used once (to
call tapctl), and that one has two backslashes now, as the

src/openvpnserv/interactive.c:    if (swprintf_s(cmd, _countof(cmd), 
L"%s\\tapctl.exe", settings.bin_dir) < 0)

adds another one...  but it will not hurt, as far as I understand.

I have changed the Subject: to not end in a single "\", because that 
upsets half my scripts later on :-)

Your patch has been applied to the master branch.

commit 985f4eaeccf0d3f9d833f3271d88634e237d7cd5
Author: Heiko Hund
Date:   Sun Nov 9 16:44:31 2025 +0100

     iservice: make sure directories have trailing backslash

     Signed-off-by: Heiko Hund <[email protected]>
     Acked-by: Lev Stipakov <[email protected]>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1336
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg34285.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to