Attention is currently required from: plaisthos, stipa.

cron2 has posted comments on this change by stipa. ( 
http://gerrit.openvpn.net/c/openvpn/+/1372?usp=email )

Change subject: tapctl: make output of 'list' and 'create' commands more verbose
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/tapctl/main.c:

http://gerrit.openvpn.net/c/openvpn/+/1372/comment/e8c04fb5_f9261de4?usp=email :
PS1, Line 292:         const WCHAR *name_to_print = final_name ? final_name : 
L"";
this looks a bit superfluous?  This branch is only entered `if (final_name)`



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1372?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iac6bcf8b5434aa414e86cb4b9742e7dd591dc796
Gerrit-Change-Number: 1372
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Fri, 14 Nov 2025 21:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to