Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change by its_Giaan. (
http://gerrit.openvpn.net/c/openvpn/+/1364?usp=email )
Change subject: multi-socket: do not return tuntap flags on server-side
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
IRC notes...
```
18:10 <@cron2> okay
18:10 <@cron2> - drop the #ifdef MULTI_DEBUG_EVENT_LOOP (completely)
18:10 <@cron2> - add the comment :-)
18:10 <@cron2> - drop FILE_CLOSED, plus explain in the commit message
18:10 <@cron2> - drop the new msg() again, because, too excessive
18:11 <@cron2> and someone needs to explain get_io_flags_dowork_udp() to me
18:11 <@cron2> why is it called "udp" and the comment says "for TCP & UDP
sockets"?
18:13 <@cron2> and why does it say "Wait for I/O events" when all it does (does
it?) is set up the flags for events we want to see?
18:14 < Giaan> probably a copy paste from it´s ancestor (io_wait())
18:15 <@cron2> should TUN_WRITE then also be removed from get_io_flags_udp()?
18:15 < Giaan> no
18:15 < Giaan> we need that for tun_set()
18:17 <@cron2> do I even dare to ask how tun_set() and get_io_flags_udp()
relate, and why get_io_flags_udp() would deal with TUN_WRITE
while get_io_flags_dowork_udp() does not?
18:17 < Giaan> ah indeed
18:17 * cron2 has to leave, and fetch the kids from sports... so will be back
tomorrow and work on this...
18:17 < Giaan> it´s related to the get_io_flags_dowork_udp()
18:18 <@cron2> (can we get rid of get_io_flags_dowork_udp()?)
18:18 <@cron2> just fold these two lines into the caller... this used to be
much larger
18:18 < Giaan> yeah, and then all the udp sockets won´t work :D
18:19 <@cron2> nah, keep the logic, but put it into get_io_flags_udp() instead
of having an extra function for just one extra function call + 1
assignment :-)
18:19 <@cron2> anyway, will be back...
18:20 < Giaan> please dump all your concerns in gerrit so we won´t forget :-)
```
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1364?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6a5110a0583b8b33496b06d9c27c1084df38e842
Gerrit-Change-Number: 1364
Gerrit-PatchSet: 2
Gerrit-Owner: its_Giaan <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: its_Giaan <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 21 Nov 2025 21:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
