Attention is currently required from: mandree, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email )
Change subject: ssl_verify_openssl: Avoid conversion warning in x509_verify_cert_ku ...................................................................... Patch Set 2: (3 comments) File src/openvpn/ssl_verify_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1445/comment/daf21b8d_ebd343a0?usp=email : PS1, Line 678: x509_verify_cert_ku(X509 *x509, const unsigned *const expected_ku, int expected_len) > expected_len might be an unsigned int or size_t to fix warnings below. Done http://gerrit.openvpn.net/c/openvpn/+/1445/comment/c6d817b4_b71d7230?usp=email : PS1, Line 714: for (int i = 0; fFound != SUCCESS && i < expected_len; i++) > If this triggers a signed/unsigned mismatch on the < - that's because the > iterator was a size_t and […] Done http://gerrit.openvpn.net/c/openvpn/+/1445/comment/f6912297_5457cc36?usp=email : PS1, Line 725: for (int i = 0; i < expected_len && expected_ku[i]; i++) > If this triggers a signed/unsigned mismatch on the < - that's because the > iterator was a size_t and […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1445?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia6c3f0395bd6cd67064fe77420d9df2b66763049 Gerrit-Change-Number: 1445 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: mandree <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: mandree <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 14:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: mandree <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
