Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1365?usp=email )
Change subject: mudp: fix handling of multiple UDP socket flags ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: Just documenting the state of this change since many discussions only seem to have happened in IRC: It is unclear whether this fix is correct. * If the flags are not cleared but preserved will the code actually handle them later? * If yes, why not replace the `else if` with just `if` and handle them directly? * If no, this patch does nothing. So this needs more testing and/or more explanation. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1365?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I509ea79990305f39e3385136fc0d9e5fbfa68e6c Gerrit-Change-Number: 1365 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: its_Giaan <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 14:37:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
